Strings cleanup #770
Merged
Strings cleanup #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addons/strings/fnc_find.sqf
Outdated
| @@ -35,31 +35,26 @@ SCRIPT(find); | |||
|
|
|||
| // ---------------------------------------------------------------------------- | |||
|
|
|||
| params ["_haystack","_needle", ["_initialIndex",0]]; | |||
| params ["_haystack","_needle", ["_initialIndex", 0]]; | |||
There was a problem hiding this comment.
...stack", "_needle...
addons/strings/fnc_formatNumber.sqf
Outdated
| @@ -64,7 +64,7 @@ Author: | |||
|
|
|||
| SCRIPT(formatNumber); | |||
|
|
|||
| params ["_number", ["_integerWidth",DEFAULT_INTEGER_WIDTH], ["_decimalPlaces",DEFAULT_DECIMAL_PLACES], ["_separateThousands",DEFAULT_SEPARATE_THOUSANDS]]; | |||
| params ["_number", ["_integerWidth", DEFAULT_INTEGER_WIDTH], ["_decimalPlaces", DEFAULT_DECIMAL_PLACES], ["_separateThousands",DEFAULT_SEPARATE_THOUSANDS]]; | |||
There was a problem hiding this comment.
, DEFAULT_SEPARATE...
addons/strings/fnc_substring.sqf
Outdated
| @@ -27,10 +27,13 @@ Author: | |||
| SCRIPT(substring); | |||
|
|
|||
| // ---------------------------------------------------------------------------- | |||
| params["_string","_startIndex","_endIndex"]; | |||
| params["_string", "_startIndex", "_endIndex"]; | |||
Dystopian
reviewed
Oct 25, 2017
addons/strings/fnc_formatNumber.sqf
Outdated
| @@ -88,4 +88,4 @@ if (_separateThousands) then { // add localized thousands seperator "1,000" | |||
|
|
|||
| if (_isNegative) then {_return = "-" + _return;}; // re-add negative sign | |||
|
|
|||
| _return | |||
| _return | |||
There was a problem hiding this comment.
Am I the one who don't like this "last return" deleting?
There was a problem hiding this comment.
Not just you, there should be an empty newline.
|
What the... |
|
Git fails to see the newline 😕 |
|
there were more than one file :) |
commy2
reviewed
Nov 3, 2017
addons/strings/fnc_find.sqf
Outdated
| -1 | ||
| }; | ||
| if (typeName _haystack != "STRING") exitWith {-1}; | ||
| if (typeName _needle != "STRING") exitWith {-1}; |
There was a problem hiding this comment.
Should change it to _var isEqualType "" too.
There was a problem hiding this comment.
Done. Also, changed the private's and exitWith's positions. There's no point in assigning vars if the script might be terminated in the next line.
commy2
reviewed
Nov 4, 2017
| if(_initialIndex > (count _haystack) ) exitWith { | ||
| -1 | ||
| }; | ||
| if (_initialIndex > (count _haystack)) exitWith {-1}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: