add optional parameter to editbox setting to obscure passwords, close #763 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
Nov 21, 2017
| @@ -89,6 +89,7 @@ switch (toUpper _settingType) do { | |||
| }; | |||
| case "EDITBOX": { | |||
| _defaultValue = _valueInfo param [0, "", [""]]; // don't use params - we want these variables to be private to the main scope | |||
| _settingData pushBack (_valueInfo param [1, false]); | |||
There was a problem hiding this comment.
Just to be safe, maybe add type checking param [1, false, [false]]
There was a problem hiding this comment.
I already have isEqualTo true check in the place where I read this one.
commy2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: