Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dialog to export and import settings text files #832

Merged
merged 7 commits into from
Dec 18, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Dec 10, 2017

When merged this pull request will:

  • fixes a bug where settings are not displayed correctly in ui after #"import"
  • copyFrom/ToClipboard has stupid limitations in MP, so let the user press Ctrl+C/V on a edit box instead

https://i.imgur.com/jvF5Xs2.jpg

It scrolls for more than 40 settings and can display thousands.

@commy2 commy2 added this to the 3.5.1 milestone Dec 10, 2017
@Dorbedo
Copy link
Contributor

Dorbedo commented Dec 12, 2017

I think, it would be an advantage, if the settings would be exported sorted by category. Maybe even with a comment.

// category 1
setting_category1_A = 1;
force setting_category1_B = 2;
// category 2
setting_category2_A = ABC;

I recognized this feature as missing while exporting the ace-settings

@Dystopian
Copy link
Contributor

it would be cool if only changed settings could be exported

@commy2
Copy link
Contributor Author

commy2 commented Dec 13, 2017

@commy2
Copy link
Contributor Author

commy2 commented Dec 13, 2017

Done and done.

@@ -15,9 +15,10 @@ Author:
---------------------------------------------------------------------------- */
#include "script_component.hpp"

params [["_source", "client", [""]]];
params [["_source", "client", [""]], ["_skipDefault", false, [false]]];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add _skipDefault to header?

@Dystopian
Copy link
Contributor

Tested, works great.
If have few non-default settings and uncheck Show default values, comments are really superfluous. It would be good to have checkbox to disable comments (and maybe double newline between categories).

@commy2
Copy link
Contributor Author

commy2 commented Dec 14, 2017

I think the comments are great and a checkbox just to disable them feels like "too much".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants