Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import handling comments and padding controls #854

Merged
merged 1 commit into from
Dec 26, 2017

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Dec 26, 2017

When merged this pull request will:

  • close Settings: Importer does not allow comments or blank lines #847 by fixing both errors mentioned
  • comment lines were not appended with a ";" if needed and therefore ate the setting of the next line
  • list setting empty padding controls used IDC_SETTING_CONTROLS_GROUP and were therefore recognized as setting controls that lacked an ui function; which in turn causes File x\cba\addons\settings\fnc_gui_refresh.sqf, line 11 etc.

@commy2 commy2 added the Bug Fix label Dec 26, 2017
@commy2 commy2 added this to the 3.6 milestone Dec 26, 2017
@commy2 commy2 merged commit 86446d3 into master Dec 26, 2017
@commy2 commy2 deleted the settings-fix-ignore-comments-correctly branch December 26, 2017 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings: Importer does not allow comments or blank lines
2 participants