Add optional mod to skip missing Mod check #866

dedmen · 2017-12-31T17:57:08Z

Provides the option to disable CBA versioning's missing Mod check which would alert everyone on clientside if client is missing a Mod that uses CBA versioning.

Allows Servers to use CBA (PFH, local events, stuff) in serverside only scripts without annoying each client with a useless message.

commy2 · 2017-12-31T18:10:19Z

addons/versioning/XEH_postInitServer.sqf

@@ -20,6 +20,9 @@ FUNC(paranoid) = {

 QGVAR(versions_serv) addPublicVariableEventHandler { (_this select 1) call FUNC(paranoid) };

+// Skip missing mod check if it is disabled.
+if (isNumber (configFile >> "CBA_skipMissingModCheck") && {getNumber (configFile >> "CBA_skipMissingModCheck") == 1}) exitWith {};


Why the isNumber check?

Not sure if the getNumber could cause errors. But as I am writing this right now I remember the talk from a couple days ago. Fix incoming

jonpas

Better name for optional would be missing_mod_check_disable or disable_missing_mod_check to go along with other optionals naming.

jonpas · 2017-12-31T18:33:59Z

optionals/no_missing_mod_check/config.cpp

+        units[] = {};
+        weapons[] = {};
+        requiredVersion = REQUIRED_VERSION;
+        requiredAddons[] = {"CBA_Extended_EventHandlers", "CBA_Versioning"};


Should be lower-case really.

Copied from cache disable

I figured, still wrong, components are all lower-case.

Uppercase CBA looks good to me tho. But the uppercase Versioning already looked weird when I wrote it.

But it's still wrong, actual component is cba_versioning. ¯\_(ツ)_/¯
Doesn't matter with Arma though.

https://github.com/CBATeam/CBA_A3/blob/master/addons/settings/config.cpp#L11 consistency then

I guess, bet there is a component that doesn't respect it. 😆

https://github.com/CBATeam/CBA_A3/blob/master/addons/main/config.cpp#L13 cough

jonpas · 2017-12-31T18:34:58Z

optionals/no_missing_mod_check/script_component.hpp

+#endif
+
+#undef REQUIRED_VERSION
+#define REQUIRED_VERSION 1.00


Pointless, this optional requires 2 other components which have required version set from main\script_mod.hpp anyways.

Same for cache disable then

jonpas · 2017-12-31T18:35:27Z

optionals/no_missing_mod_check/script_component.hpp

+#include "\x\cba\addons\main\script_mod.hpp"
+
+
+#ifdef DEBUG_ENABLED_CACHE_DISABLE


Should be #ifdef DEBUG_ENABLED_NO_MISSING_MOD_CHECK.

jonpas · 2017-12-31T18:35:43Z

optionals/no_missing_mod_check/script_component.hpp

+	#define DEBUG_MODE_FULL
+#endif
+
+#ifdef DEBUG_SETTINGS_CACHE_DISABLE


Should be #ifdef DEBUG_ENABLED_NO_MISSING_MOD_CHECK.

jonpas · 2017-12-31T18:36:23Z

optionals/no_missing_mod_check/script_component.hpp

+#endif
+
+#ifdef DEBUG_SETTINGS_CACHE_DISABLE
+	#define DEBUG_SETTINGS DEBUG_SETTINGS_CACHE_DISABLE


Should be #define DEBUG_SETTINGS DEBUG_SETTINGS_NO_MISSING_MOD_CHECK.

commy2 · 2017-12-31T22:13:37Z

I think the name missing_mod_check is weird. It's atm called "versioning".
Disabling it completely is a bit odd. Someone could still want it, but only ignore one certain addon.
Btw. which addon are we talking about? Because unlike ACE_checkPBO, this only works for addons that have it enabled via config. Shouldn't that optional addon be disabled instead?

dedmen · 2017-12-31T22:43:06Z

I don't think I disable versioning completly (https://github.com/CBATeam/CBA_A3/blob/master/addons/versioning/XEH_postInitClient.sqf <- That is version comparison). I only disable the missing mod check.
I basically want CBA on the Server without telling clients they are missing it.
So I guess this is about disabling the check for all of CBA.

commy2 · 2018-02-13T12:42:43Z

Related: #871

name was changed

jonpas · 2018-02-14T19:20:58Z

I still don't see why it has to be an optional PBO, when it could be just a config entry which people can define in description.ext as well. Or a setting itself as @commy2 suggested on Slack.

In short it should literally be identical to enableTargetDebug (which could also be a setting).

see jonpa's comment

dedmen · 2018-02-15T07:28:07Z

So what now? CBA setting or config? Or both?
I'd say CBA setting is enough. But it would be a serverside only setting. And would that be the first CBA setting inside CBA itself? :D

dedmen · 2018-04-20T10:48:32Z

A CBA setting for this would be "confusing" because it's only relevant on serverside. Meaning it shouldn't show up on client/mission settings which afaik isn't supported in CBA settings currently.

Also to enable the setting you would then either need a serverside userconfig for the settings or you'd have to connect with CBA enabled on clientside and then configure it. Which is a chore on a vanilla server with bisigning enabled.

Jonpas to do it the same way as enableTargetDebug which is a mission specific attribute.
I don't think a thing that is hidden on the server-backend should be a mission attribute that you have to set in every mission.
My concern is server-side only mods that require CBA. You shouldn't have to edit every of your missions just to run a server-side mode that might have nothing to do with the mission.

I'm still for optional-pbo. In my case I want this for server-side Intercept. And as all users already need a PBO with config to register their plugin they could also add the config entry into their pbo instead of loading the CBA optional.
The optional PBO also shows everyone that, that feature exists. And people might also want to use that outside of just serverside intercept and without having to build their own pbo.

I guess it wouldn't hurt to make it configFile or missionConfigFile. Just to let all options open.

skip

2eedce7

commy2 reviewed Dec 31, 2017

View reviewed changes

no isNumber

e78e44c

dedmen mentioned this pull request Dec 31, 2017

Remove XEH eventhandlers intercept/intercept#186

Open

jonpas previously requested changes Dec 31, 2017

View reviewed changes

dedmen added 2 commits December 31, 2017 19:42

Typo's/formatting

c02d567

rename

2474b6a

commy2 added this to the 3.7 milestone Dec 31, 2017

commy2 added the Enhancement label Feb 8, 2018

commy2 self-assigned this Feb 13, 2018

commy2 previously approved these changes Feb 13, 2018

View reviewed changes

Rename config entry to disableX

6efb5f6

commy2 modified the milestones: 3.7, 3.8 Apr 14, 2018

commy2 modified the milestones: 3.8, 3.7 Apr 29, 2018

Killswitch00 merged commit 920dc5f into CBATeam:master Apr 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add optional mod to skip missing Mod check #866

Add optional mod to skip missing Mod check #866

dedmen commented Dec 31, 2017

commy2 Dec 31, 2017

dedmen Dec 31, 2017

jonpas left a comment

jonpas Dec 31, 2017

dedmen Dec 31, 2017

jonpas Dec 31, 2017

dedmen Dec 31, 2017

jonpas Dec 31, 2017 •

edited

Loading

dedmen Dec 31, 2017

jonpas Dec 31, 2017

dedmen Dec 31, 2017

jonpas Dec 31, 2017

dedmen Dec 31, 2017

jonpas Dec 31, 2017

jonpas Dec 31, 2017

jonpas Dec 31, 2017

commy2 commented Dec 31, 2017

dedmen commented Dec 31, 2017 •

edited

Loading

commy2 commented Feb 13, 2018

jonpas commented Feb 14, 2018

dedmen commented Feb 15, 2018 •

edited

Loading

dedmen commented Apr 20, 2018

		#include "\x\cba\addons\main\script_mod.hpp"


		#ifdef DEBUG_ENABLED_CACHE_DISABLE

Add optional mod to skip missing Mod check #866

Add optional mod to skip missing Mod check #866

Conversation

dedmen commented Dec 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonpas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonpas Dec 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

commy2 commented Dec 31, 2017

dedmen commented Dec 31, 2017 • edited Loading

commy2 commented Feb 13, 2018

jonpas commented Feb 14, 2018

dedmen commented Feb 15, 2018 • edited Loading

dedmen commented Apr 20, 2018

jonpas Dec 31, 2017 •

edited

Loading

dedmen commented Dec 31, 2017 •

edited

Loading

dedmen commented Feb 15, 2018 •

edited

Loading