Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create vectorRotate3D.sqf #898

Closed
wants to merge 5 commits into from
Closed

Create vectorRotate3D.sqf #898

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
048a6af
Create vectorRotate3D.sqf
LorenLuke Mar 6, 2018
d91502d
Reformats header and fixes typos.
LorenLuke Mar 6, 2018
cdd2f36
Added new SUPER! header
LorenLuke Mar 6, 2018
65c669f
Adds Tests
LorenLuke Mar 6, 2018
07174a7
update formatting, camel case varnames, fixed undefined variable
commy2 Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions addons/vectors/fnc_vectorRotate3D.sqf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header style doesn't match rest of CBA
https://github.com/CBATeam/CBA_A3/blob/master/addons/vectors/fnc_vectRotate2D.sqf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better header with examples and such:
https://github.com/CBATeam/CBA_A3/blob/master/addons/settings/fnc_init.sqf

* Author: LorenLuke
* Rotates the first vector around the second, clockwise by angle theta
*
* Arguments:
* 0: Vector <ARRAY>
* 1: Rotation Axis <ARRAY>
* 2: Angle (degrees) <NUMBER>
*
* Return Value:
* Transformed Vector <ARRAY>
*
* [weaponDir player, [0,0,1], 25] call CBA_fnc_vectorRotate3D
*
* Public: No
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be public though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of CBA's header anyways.

*/
#include "script_component.hpp"

params ["vector", "_rotationAxis", "_theta"];

private _normalVector = vectorNormalized _rotationAxis;
private = _s_theta = sin(_theta);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo =

private = _c_theta = cos(_theta);

// Rodrigues Rotation Formula;
// https://wikimedia.org/api/rest_v1/media/math/render/svg/2d63efa533bdbd776434af1a7af3cdafaff1d578
private _returnVector =
(_vector1 vectorMultiply _c_theta) vectorAdd
((_normalVector vectorCrossProduct _vector1) vectorMultiply _s_theta) vectorAdd
(
_normalVector vectorMultiply ((_normalVector vectorDotProduct _vector1) * (1 - _c_theta))
);

_returnVector;