Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CBA_fnc_vectRotate3D #906

Merged
merged 9 commits into from
Apr 15, 2018
Merged

Add CBA_fnc_vectRotate3D #906

merged 9 commits into from
Apr 15, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Apr 14, 2018 •
edited
Loading

Can't push to remote branch, so fixes go here. Was undefined, which is fixed.

@commy2 commy2 added the Feature label Apr 14, 2018
@commy2 commy2 added this to the 3.7 milestone Apr 14, 2018
@commy2 commy2 self-assigned this Apr 14, 2018
@commy2 commy2 changed the title CBA_fnc_ Add CBA_fnc_vectRotate3D Apr 14, 2018
@commy2
Copy link
Contributor Author

commy2 commented Apr 14, 2018

Error is from rounding:

[[0,1,0],[1,0,0],90] call CBA_fnc_vectRotate3D
// [0,-4.37114e-008,1]
// [0,0,1] expected

@commy2
Copy link
Contributor Author

commy2 commented Apr 14, 2018

http://www.nh.cas.cz/people/lazar/celler/online_tools.php?start_vec=0,1,0&rot_ax=0,0,1&rot_ang=-45

@commy2
Copy link
Contributor Author

commy2 commented Apr 14, 2018 

execVM "\x\cba\addons\vectors\test_vectors.sqf"
18:38:57 [CBA] (vectors) LOG: Testing Vectors x\cba\addons\vectors\test_vectors.sqf:24
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_polar2vect is defined) x\cba\addons\vectors\test_vectors.sqf:28
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:32
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:36
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:40
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:44
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_scaleVect is defined) x\cba\addons\vectors\test_vectors.sqf:49
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:53
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:57
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:61
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_scaleVectTo is defined) x\cba\addons\vectors\test_vectors.sqf:66
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:70
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:74
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:78
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:82
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_simplifyAngle is defined) x\cba\addons\vectors\test_vectors.sqf:87
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle x\cba\addons\vectors\test_vectors.sqf:91
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle x\cba\addons\vectors\test_vectors.sqf:95
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle x\cba\addons\vectors\test_vectors.sqf:99
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_simplifyAngle180 is defined) x\cba\addons\vectors\test_vectors.sqf:104
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle180 x\cba\addons\vectors\test_vectors.sqf:108
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle180 x\cba\addons\vectors\test_vectors.sqf:112
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_simplifyAngle180 x\cba\addons\vectors\test_vectors.sqf:116
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vect2Polar is defined) x\cba\addons\vectors\test_vectors.sqf:121
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:125
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:129
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:133
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:137
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectAdd is defined) x\cba\addons\vectors\test_vectors.sqf:143
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:147
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:151
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectCross is defined) x\cba\addons\vectors\test_vectors.sqf:157
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:161
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectCross2D is defined) x\cba\addons\vectors\test_vectors.sqf:166
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectCross2D x\cba\addons\vectors\test_vectors.sqf:170
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectDir is defined) x\cba\addons\vectors\test_vectors.sqf:175
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDir x\cba\addons\vectors\test_vectors.sqf:179
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDir x\cba\addons\vectors\test_vectors.sqf:183
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectDot is defined) x\cba\addons\vectors\test_vectors.sqf:188
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDot x\cba\addons\vectors\test_vectors.sqf:192
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectDot x\cba\addons\vectors\test_vectors.sqf:196
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectElev is defined) x\cba\addons\vectors\test_vectors.sqf:201
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectElev x\cba\addons\vectors\test_vectors.sqf:205
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectElev x\cba\addons\vectors\test_vectors.sqf:209
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectMagn is defined) x\cba\addons\vectors\test_vectors.sqf:214
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn x\cba\addons\vectors\test_vectors.sqf:218
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn x\cba\addons\vectors\test_vectors.sqf:222
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectMagn2D is defined) x\cba\addons\vectors\test_vectors.sqf:227
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn2D x\cba\addons\vectors\test_vectors.sqf:231
18:38:57 [CBA] (vectors) Test OK: (_result == _expected) CBA_fnc_vectMagn2D x\cba\addons\vectors\test_vectors.sqf:235
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectRotate2D is defined) x\cba\addons\vectors\test_vectors.sqf:240
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:244
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:248
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectRotate3D is defined) x\cba\addons\vectors\test_vectors.sqf:252
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:256
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:260
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:264
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:268
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:272
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:276
18:38:57 [CBA] (vectors) Test OK: (CBA_fnc_vectSubtract is defined) x\cba\addons\vectors\test_vectors.sqf:280
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:284
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:291
18:38:57 [CBA] (vectors) Test OK: ([_result, _expected] call _fnc_vectorEquals) x\cba\addons\vectors\test_vectors.sqf:296

@Killswitch00 Killswitch00 merged commit ea18870 into master Apr 15, 2018
@commy2 commy2 deleted the LorenLuke-patch-1 branch April 15, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
Feature
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@commy2 @Killswitch00 @LorenLuke