Cache CreditsLine entries #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love you. |
commy2
approved these changes
May 17, 2018
shukari
reviewed
Jun 5, 2018
| @@ -29,11 +29,7 @@ if (CBA_DisableCredits) exitWith {}; | |||
|
|
|||
| // find addon with author | |||
| private _config = configFile >> "CfgPatches"; | |||
There was a problem hiding this comment.
This line is also now obsolete... _config never get used in that script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cba_help_fnc_setCreditsLine is the major lag cause when opening the Pause menu.
This is a very simple fix to get rid of that.
Scanning all CfgPatches entries everytime a player presses Escape wasn't a good idea in the first place.
The entire frame is 60.5 ms and CBA creditsLine is 35ms of that. And it get's worse the more mods you have.