Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BIS_fnc_getCfgData with engine command #932

Merged
merged 1 commit into from
Jun 30, 2018
Merged

Replace BIS_fnc_getCfgData with engine command #932

merged 1 commit into from
Jun 30, 2018

Conversation

Wakbub
Copy link
Contributor

@Wakbub Wakbub commented May 25, 2018 •
edited
Loading

When merged this pull request will:

  • Replace BIS function call BIS_fnc_getCfgData with with engine command getText.

Links

@Wakbub
Replace BIS function with engine command
c0bad84 
Replace BIS function (*BIS_fnc_getCfgData*) with with engine command (*getText*).

Links:
[BIS_fnc_getCfgData](https://community.bistudio.com/wiki/BIS_fnc_getCfgData)
[getText](https://community.bistudio.com/wiki/getText)
@dedmen
Copy link
Contributor

dedmen commented May 25, 2018

Old one supports Number, Text and Array.
New one only supports text?

@PabstMirror
Copy link
Contributor

It just does hintSilent format ["%1", _switchItemHintText]
So number/array wouldn't make much sense

@Wakbub
Copy link
Contributor Author

Wakbub commented May 25, 2018

MRT_SwitchItemHintText is always Text, so there is no point in "supporting" other types.

@Wakbub Wakbub changed the title Replace BIS function with engine command Replace BIS function call with engine command May 25, 2018
@commy2
Copy link
Contributor

commy2 commented May 26, 2018

I'd rather have someone make a nicer looking ui element, possibly one that can be reused for other purposes and other mods.

@commy2 commy2 added this to the 3.8 milestone Jun 25, 2018
@commy2 commy2 self-assigned this Jun 25, 2018
@commy2 commy2 merged commit 41174e0 into CBATeam:master Jun 30, 2018
@commy2 commy2 changed the title Replace BIS function call with engine command Replace BIS_fnc_getCfgData with engine command Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@commy2 commy2

Labels
None yet
Projects
None yet
Milestone
3.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Wakbub @dedmen @PabstMirror @commy2