Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resetting mission settings #945

Merged
merged 1 commit into from
Jun 30, 2018
Merged

fix resetting mission settings #945

merged 1 commit into from
Jun 30, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jun 30, 2018

When merged this pull request will:

In 3DEN and if the mission settings file exists, set is called for all settings with the value from the mission settings file. For settings undefined in the mission settings file, this value is nil.
set handles nil values by changing them to the default value.
set is called without the "store" flag, so when using the preview or when putting the mission on a server, the correct setting would be read from mission.sqm. Only in the editor the setting would be wrong temporarily after the settings menu is opened.

This PR fixes that by not using set for settings that are left out of the settings file.

@commy2 commy2 added the Bug Fix label Jun 30, 2018
@commy2 commy2 added this to the 3.8 milestone Jun 30, 2018
@commy2 commy2 merged commit 5ee4fa4 into master Jun 30, 2018
@commy2 commy2 deleted the fix930 branch June 30, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cba_settings.sqf breaks addon settings UI
2 participants