Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - Keep getFov params consistant with previous versions #956

Merged
merged 1 commit into from
Aug 1, 2018
Merged

UI - Keep getFov params consistant with previous versions #956

merged 1 commit into from
Aug 1, 2018

Conversation

PabstMirror
Copy link
Contributor

@kymckay
Copy link
Contributor

kymckay commented Jul 29, 2018

I prefer the usage of params personally, it slightly changes the behaviour here, but I think it's preferable to flag incorrect/unintended input parameters.

@commy2
Copy link
Contributor

commy2 commented Jul 29, 2018

The behaviour is the same, except for the on screen messgae if -showScriptErrors is enabled / in 3den/3den preview.

@PabstMirror
Copy link
Contributor Author

If _this is [0] the behaviour will be different

I know plenty of people do play with script errors on
Perhaps, we should merge this and @alganthe's PRs and then switch to params for next CBA

@ViperMaul ViperMaul merged commit 96ed109 into master Aug 1, 2018
@PabstMirror PabstMirror deleted the fovParams branch August 1, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thojkooi thojkooi thojkooi approved these changes

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PabstMirror @kymckay @commy2 @thojkooi @ViperMaul