Workaround for settings size limitation #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how about |
Exactly what he linked I assume. |
🤦♂️ Too hot outside. |
allow sound mods and other small client side mods and you have so much in ace_common_checkPBOsWhitelist. and good idea with joinString. will do |
commy2
reviewed
Aug 8, 2018
addons/settings/fnc_parse.sqf
Outdated
| @@ -27,7 +27,7 @@ private _fnc_parseAny = { | |||
| _string = _string splitString WHITESPACE joinString ""; | |||
| }; | |||
|
|
|||
| parseSimpleArray format ["[%1]", _string] select 0 | |||
| parseSimpleArray (["[", _string, "]"] joinString "") select 0; | |||
There was a problem hiding this comment.
I left out the semi colon to indicate the scope's return value.
jonpas
changed the title
commy2
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is a workaround that fixes an issue that settings could only be 8kb long due to the use of format.
example: https://gist.github.com/neilzar/cdf4fa7a06d43560df64eea36c2cffb5
parse throws the error