Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tooltip about required mission start #960

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Aug 10, 2018

When merged this pull request will:

  • Adds this revolutionary new concept called "tooltip" explaining why you cannot edit the addon settings or addon keybinds in main menu or mission select screen

@commy2 commy2 added this to the 3.8.1 milestone Aug 10, 2018
@@ -10,5 +10,9 @@
<French>Community Base Addons - Composants communs</French>
<Polish>Community Base Addons - Ogólne Komponenty</Polish>
</Key>
<Key ID="STR_cba_common_need_mission_start">
<English>You must first start a mission.</English>
Copy link
Contributor

@Dystopian Dystopian Aug 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it sound too personal? Maybe something like Mission must be started.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of a verb used in the imperative mood is the English sentence "Please be quiet". Such imperatives imply a second-person subject (you)[.]

Using the imperative is the best way to guide the user by tooltip in my experience.

@Killswitch00 Killswitch00 merged commit 46ead80 into master Aug 19, 2018
@commy2 commy2 deleted the must-start-mission-tooltip branch August 19, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants