Settings - Add time setting type #967
Conversation
| @@ -40,5 +40,9 @@ switch (toUpper _settingType) do { | |||
| case "COLOR": { | |||
| _value isEqualType [] && {count _value == count _defaultValue} && {_value isEqualTypeAll 0} && {{_x < 0 || _x > 1} count _value == 0} | |||
| }; | |||
| case "TIME": { | |||
| _settingData params ["_min", "_max"]; | |||
| _value isEqualType 0 && {_value >= _min} && {_value <= _max} && {round _value == _value} | |||
There was a problem hiding this comment.
round _value == _value
Why?
There was a problem hiding this comment.
Since the visual doesn't show decimals, checking if rounded like the default slider
There was a problem hiding this comment.
If SLIDER does the same, then I suppose this is correct.
addons/settings/fnc_init.sqf
Outdated
| ["Test_Setting_5", "EDITBOX", ["-test editbox-", "-tooltip-"], "My Category", "defaultValue"] call cba_settings_fnc_init; | ||
|
|
||
| // TIME PICKER --- extra arguments: [_min, _max, _default] | ||
| ["Test_Setting_6", "TIME", ["-test time-", "-tooltip-"], "My Category", [0, 3600, 60]] call cba_settings_fnc_init; |
There was a problem hiding this comment.
Should mention "time in seconds" somewhere.
addons/settings/script_component.hpp
Outdated
| //#define DEBUG_ENABLED_SETTINGS | ||
| #define DEBUG_MODE_FULL | ||
| #define DISABLE_COMPILE_CACHE | ||
| #define DEBUG_ENABLED_SETTINGS |
addons/settings/gui.hpp
Outdated
| class Hours: RscEdit { | ||
| idc = IDC_SETTING_TIME_HOURS; | ||
| style = ST_CENTER + ST_NO_RECT; | ||
| text = "00"; |
There was a problem hiding this comment.
Omg I need this for the SLIDER.
|
If the edit boxes are used instead of the slider, the control does not correctly tick "overwrite client" when altered in the MISSION tab, and does not highlight as yellow when changed. // automatically check "overwrite client" for mission makers qol
[_controlsGroup, _source] call (_controlsGroup getVariable QFUNC(auto_check_overwrite));in the keyUp event. The other purpose of the keyUp event is to trim non number chars, which is done beautifully with the |
|
Will add the line to indicate a changed value to the KillFocus event. Like the 3DEN attribute, the value does not update with a KeyUp event. A KeyUp event could be added but I think the UX might be better without it. Also, unfortunately, the |
| _x params ["_idc", "_value"]; | ||
|
|
||
| private _ctrlEdit = _controlsGroup controlsGroupCtrl _idc; | ||
| private _editText = if (_value < 10) then {format ["0%1", _value]} else {str _value}; |
There was a problem hiding this comment.
Replace with CBA_fnc_formatNumber?
There was a problem hiding this comment.
Could do, but this works too. Only difference I believe would be rounding instead of truncating.
|
I would personally remove the slider altogether for these settings because it clutters the UI. I can't decide if I like including upper and lower limits for these 🤔 My gut says that time settings shouldn't be bound by limits (with the exception that negative time shouldn't be allowed) because otherwise why not just use a slider? |
|
SLIDER doesn't give feedback how long something takes in HH:MM:SS format. |
|
On further consideration I think ideally the min and max should be optional for time settings. There are many use cases where you might want the user to select a time, but it doesn't matter how long/short it is. I'd still remove the slider in the menu either way though. |
|
TIME vs DATE? |
|
Nah, in general I'd say if you want a time from the user you wouldn't want to limit it. Example: Cardiac arrest timer in ACE medical rewrite, prime use case for a time setting, but there's no purpose in limiting how long people should be able to set it. |
|
That's true for all sliders I suppose, but you could always make the maximum something unreasonable like 1 or maybe even 10 hours. |
|
I am indifferent about including the slider but I think it is easier to change the value using it rather than the edit boxes (the 3DEN attribute has a slider). And I agree, the maximum limit can be set to something unreasonable, which for the settings this is intended for will probably be 24 hours? |
|
You've swayed me on the sliders 😄 Which in turn means limits make sense. No more considerations here from me 👍 |
|
I think this is done. Only thing maybe would adding a KeyUp event for trimming non-number chars and updating value on key press but I don't think it is necessary. |
When merged this pull request will: