Keybinding - Highlight individual duplicate keys #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
reviewed
Aug 31, 2018
addons/keybinding/fnc_gui_update.sqf
Outdated
|
|
||
| _keyNames pushBack _keyName; | ||
| _keybind in _duplicateKeybinds && {_action != _duplicateAction} | ||
| } > -1) then { |
There was a problem hiding this comment.
Very cool. Apparently Travis doesn't understand if findIf.
commy2
reviewed
Aug 31, 2018
addons/keybinding/fnc_gui_update.sqf
Outdated
| _assigned ctrlSetTextColor [1,0,0,1]; | ||
| }; | ||
| _assigned ctrlSetTooltipColorBox [1,1,1,1]; | ||
| _assigned ctrlSetTooltipColorShade [0,0,0,0.7]; |
There was a problem hiding this comment.
These already were the values used I believe. Although setting them explicitly may be more robust if future changes happen (e.g. by BI).
There was a problem hiding this comment.
RscStructuredText, unlike RscText, has no entries for tooltip defined, and the defaults look different to these. Should probably just move these to config though.
|
Fixed for the code validation. |
commy2
approved these changes
Sep 1, 2018
commy2
approved these changes
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
_editand_assigned