Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make server browser remember last used password for every server #973

Merged
merged 7 commits into from
Sep 10, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 7, 2018

Clan got annoyed entering the same password twice a week. Therefore:

When merged this pull request will:

  • make the serverbrowser remember the last used password for every server

The passwords are saved in profile, and could theoretically read by malicious scripts. There is a client only setting (ADDON OPTIONS -> CBA UI) to change the saving behavior for security reasons. No one should care about game server passwords, but whatever, here it is:

  • Save passwords (default)
    -- passwords are stored when connecting to a multiplayer server
    -- stored passwords are automatically entered when trying to connect to a previous server

  • Do not save passwords
    -- passwords are not stored when connecting to a multiplayer server
    -- already stored passwords will not be automatically entered

  • Delete passwords
    -- passwords are not stored when connecting to a multiplayer server
    -- already stored passwords will not be automatically entered
    -- already stored passwords are deleted from the profile

@commy2 commy2 added the Feature label Sep 7, 2018
@commy2 commy2 added this to the 3.8.1 milestone Sep 7, 2018
@commy2 commy2 changed the title make serverbrowser remember last used password for every server make server browser remember last used password for every server Sep 7, 2018
@commy2 commy2 merged commit e2e4266 into master Sep 10, 2018
@commy2 commy2 deleted the remember-passwords branch September 10, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants