Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add searchbar to mission browser #974

Merged
merged 6 commits into from
Sep 13, 2018
Merged

add searchbar to mission browser #974

merged 6 commits into from
Sep 13, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 7, 2018 •
edited
Loading

When merged this pull request will:

  • same as SP scenario browser

@commy2 commy2 added the WIP label Sep 7, 2018
@commy2 commy2 added Feature and removed WIP labels Sep 7, 2018
@commy2
Copy link
Contributor Author

commy2 commented Sep 7, 2018

https://i.imgur.com/yYCSQJZ.png

@commy2 commy2 added this to the 3.8.1 milestone Sep 7, 2018
mharis001
mharis001 approved these changes Sep 9, 2018
View reviewed changes
Copy link
Contributor

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested in-game, works well 👍

Comments I left are just to have slightly better alignment of search box since, edit controls protrude a little bit due to the outline

addons/ui/fnc_initDisplayRemoteMissions.sqf Outdated

private _ctrlSearch = _display ctrlCreate ["RscEdit", IDC_SEARCH];
_ctrlSearch ctrlSetPosition [
_left,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_left + 0.1 * GUI_GRID_W

addons/ui/fnc_initDisplayRemoteMissions.sqf Outdated
_ctrlSearch ctrlSetPosition [
_left,
_top,
_width - GUI_GRID_W,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_width - 1.2 * GUI_GRID_W

addons/ui/fnc_initDisplayRemoteMissions.sqf Outdated
_left,
_top,
_width - GUI_GRID_W,
GUI_GRID_H
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.9 * GUI_GRID_H

@commy2
Copy link
Contributor Author

commy2 commented Sep 13, 2018

Kept the size of the edit box, because it looked a bit squashed, and moved the listbox below down a bit instead.

@commy2 commy2 merged commit e13258f into master Sep 13, 2018
@commy2 commy2 deleted the mission-browser-search branch September 13, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedmen dedmen dedmen approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

@mharis001 mharis001 mharis001 approved these changes

Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
3.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@commy2 @dedmen @PabstMirror @mharis001