Notification #999
Notification #999
Conversation
|
👎 don't like the use of spawn in there. should use waitAndExecute and waitUntilAndExecute maybe instead? |
|
I didn't use waitAndExecute since it has multiple blocks requiring sleep. This would require nesting would it not? I thought the use of sleep 3 times would be better overall than nesting 3 times |
|
I would build it more like a message queue so that you don't need to wait multiple times for every notification. so that you have a function that just enqueues the notification, and one that pulls one and draws it and after x amount of time hides it and recalls itself to check if the queue is empty and when then just stops. with that, you only have X "tasks" running at the same time and not a "task" for every notification. |
|
Wouldn't that require a task running during the entire mission to check the queue? Where as this method has no background tasks running while there a no notifications. Considering that these notifications would rarely be shown isn't this way better? Even though if 3 notifications are being shown, there are 3 tasks, there should rarely be 3 notifications. |
no, because the function is called when you add a new notification. the draw function/tasks are only running when there is currently a notification on screen or in Queue. but than only the max amount of notifications that can get shown at the same time. and not more. |
ah I see, I hadn't considered that way |
| waitUntil {_index - GVAR(NotificationCurrentIndex) < GVAR(NotificationMax)}; | ||
|
|
||
| private _position = _index % GVAR(NotificationMax); | ||
| private _safezoneX = safezoneW + safezoneX; |
There was a problem hiding this comment.
This is the right edge of the (middle) screen. Safezone is a misleading variable name.
|
|
||
| // Create the 3 displays in the offscreen position | ||
|
|
||
| private _ctrlBackground = _display ctrlCreate ["RscPicture", 20]; |
There was a problem hiding this comment.
Magic variable should be a macro.
| 0.1 * safezoneW, | ||
| 0.06 * safezoneH | ||
| ]; | ||
| _ctrlBackground ctrlSetText "#(argb,8,8,3)color(0,0,0,0.75)"; |
There was a problem hiding this comment.
I feel like this should use ctrlSetBackgroundColor instead. This as picture control seems awkward to me at least.
| _ctrlBackground ctrlSetText "#(argb,8,8,3)color(0,0,0,0.75)"; | ||
| _ctrlBackground ctrlCommit 0; | ||
|
|
||
| private _ctrlTitle = _display ctrlCreate ["RscStructuredText", 10]; |
There was a problem hiding this comment.
Magic variable should be a macro.
| _ctrlTitle ctrlSetTextColor _color; | ||
| _ctrlTitle ctrlCommit 0; | ||
|
|
||
| private _ctrlNotification = _display ctrlCreate ["RscStructuredText", 30]; |
There was a problem hiding this comment.
Magic variable should be a macro.
|
|
||
| private _ctrlNotification = _display ctrlCreate ["RscStructuredText", 30]; | ||
| _ctrlNotification ctrlSetPosition | ||
| [ |
There was a problem hiding this comment.
Inconsistent formatting. I prefer L57 & L67, and that is the style used in CBA in most places.
| private _posX = 0.9 * safezoneW + safezoneX; | ||
| _position set [0, _posX]; | ||
| _x ctrlSetPosition _position; | ||
| _x ctrlCommit (uiNamespace getVariable [QGVAR(NotificationSpeed), 0.5]); |
There was a problem hiding this comment.
Why are these ui namespace? Doesn't settings put the variables in mission namespace? It seems weird to put this into ui namespace.
|
Not happy about this being scheduled. Basically breaks if you save and load a savegame or have poor FPS in MP. |
|
This should be a controls group control template in config, so the script doesn't have to recreate the whole thing with slow sqf every time. |
Notifications - Polish translation
|
|
|
That's what it looks like? Wildly different from my PC. I am going to be rewriting this PR after my exams anyway. |
|
I have a counter proposal here: #1036, which is kind of a port from the ACE one. It's compatible with the BI Layout editor. |
When merged this pull request will: