Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate python scripts #59

Closed
2 tasks done
Tracked by #55
ggutierrez-sunbright opened this issue Dec 22, 2023 · 0 comments · Fixed by #73
Closed
2 tasks done
Tracked by #55

migrate python scripts #59

ggutierrez-sunbright opened this issue Dec 22, 2023 · 0 comments · Fixed by #73
Labels
enhancement New feature or request rdock-utils

Comments

@ggutierrez-sunbright
Copy link
Contributor

ggutierrez-sunbright commented Dec 22, 2023

@ggutierrez-sunbright ggutierrez-sunbright changed the title migrate scripts migrate python scripts Dec 23, 2023
lpardey added a commit to SunBright-Technologies/rDock that referenced this issue Jan 9, 2024
lpardey added a commit to SunBright-Technologies/rDock that referenced this issue Jan 25, 2024
ggutierrez-sunbright pushed a commit that referenced this issue Jan 25, 2024
* add numpy and openbabel as requirements

* add files to ignore

* refactor to python3 and add typing for superpose3D, squared_distance and rmsd functions

* add typing for coordinates
add and refactor  map_to_crystal function

* add parseArguments function with type annotations

* update variable and function names
add update_coordinates function with type annotations

* add get_automorphism_RMSD function with type annotations

* add save_molecule_with_RMSD function with type annotation

* refactor superpose_3D function

* update save_molecule_with_rmsd: remove unnecessary condition
add main function

* add aligned-fit sdf test file

* add aligned-nofit sdf test file

* add input sdf test file

* add ref sdf test file

* add conftest with fixtures folder path as constant

* add sdrms conftest file

* add aligned molecules raw data fixture

* add aligned fit molecule raw data fixture

* add integration tests

* code formatting

* add aligned_nofit_filename and aligned_fit_filename fixtures

* add testing comparison functions for molecules:
- atoms_are_equal
- molecules_are_equal
- compare_sdf_files

* extract parser to its own file

* add sdrmsd script package to pyproject.toml

* update github actions workflow for rdock-utils
  - add ruff
  - remove flake, black, isort
  - add pytest

* add dynamic dependencies to pyproject.toml

* remove unnecessary docstrings

* add old sdrmrsd to be execute as script

* lint and typing
ggutierrez-sunbright pushed a commit that referenced this issue Jan 25, 2024
* migrate old sdtether script to python3

* add old sdtether to be execute as script
exclude old sdtether (ruff and mypy)
ggutierrez-sunbright pushed a commit that referenced this issue Jan 27, 2024
* add numpy and openbabel as requirements

* add files to ignore

* refactor to python3 and add typing for superpose3D, squared_distance and rmsd functions

* add typing for coordinates
add and refactor  map_to_crystal function

* add parseArguments function with type annotations

* update variable and function names
add update_coordinates function with type annotations

* add get_automorphism_RMSD function with type annotations

* add save_molecule_with_RMSD function with type annotation

* refactor superpose_3D function

* update save_molecule_with_rmsd: remove unnecessary condition
add main function

* add aligned-fit sdf test file

* add aligned-nofit sdf test file

* add input sdf test file

* add ref sdf test file

* add conftest with fixtures folder path as constant

* add sdrms conftest file

* add aligned molecules raw data fixture

* add aligned fit molecule raw data fixture

* add integration tests

* code formatting

* add aligned_nofit_filename and aligned_fit_filename fixtures

* add testing comparison functions for molecules:
- atoms_are_equal
- molecules_are_equal
- compare_sdf_files

* extract parser to its own file

* add sdrmsd script package to pyproject.toml

* update github actions workflow for rdock-utils
  - add ruff
  - remove flake, black, isort
  - add pytest

* add dynamic dependencies to pyproject.toml

* remove unnecessary docstrings

* add old sdrmrsd to be execute as script

* lint and typing
ggutierrez-sunbright pushed a commit that referenced this issue Jan 27, 2024
* migrate old sdtether script to python3

* add old sdtether to be execute as script
exclude old sdtether (ruff and mypy)
lpardey added a commit to SunBright-Technologies/rDock that referenced this issue Feb 1, 2024
ggutierrez-sunbright added a commit that referenced this issue Feb 1, 2024
* extract superpose3d and type modules to a common package

* add sdtether to project scritps

* add parser module

* add sdtether

* add main file

* migrate update_coordinates method to common package

* add fixture data for testing sdtether

* fix sdtether original argument parsing

* add basic test for sdtether

* refactor rmsd method
update typing
squared_distance method is not necessary anymore

* refactor superpose3d:
modified the class interface and fix several bugs
class works with sdrmsd and sdtether as well

* refactor:
- remove _get_ref_matches_align_data, match_to_mask and get_matches functions.
- add show_matches_info function
- add ref_mol, ref_matches and ref_align_data as instance attributes
- update run, process_molecule and write_aligned_molecule functions

* add test_get_centroid for superposer3d module

* fix mypy

* add show_mol_mathches_info feature
* add skipped molecule logger info on process_molecule method

---------

Co-authored-by: ggutierrez-sunbright <94693768+ggutierrez-sunbright@users.noreply.github.com>
lpardey added a commit to SunBright-Technologies/rDock that referenced this issue Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rdock-utils
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant