Perfusion-related fixes (PHI, PerfusionPCA, GUI/CLI) #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check needed to be done for loading 4D and having 4D loaded.
AlexanderGetka-cbica
requested review from
ashishsingh18 and
sarthakpati
and removed request for
sarthakpati and
ashishsingh18
|
Are we trying to fix Codacy issues, as well? For e.g.:
|
Ah, yeah -- I should've caught that. My bad. I won't change the code-style related ones for this but I'll address any "medium" or above. |
AlexanderGetka-cbica
requested review from
sarthakpati
and removed request for
sarthakpati
sarthakpati
approved these changes
Mar 11, 2022
sarthakpati
suggested changes
Mar 11, 2022
Comment on lines
+1832
to
+1845
| /*auto originalDirection = imageInfo.GetImageDirections(); | ||
| ImageTypeFloat3D::DirectionType originalDirectionIn3D; | ||
| for (int i = 0; i < 3; i++) | ||
| { | ||
| for (int j = 0; j < 3; j++) | ||
| { | ||
| originalDirectionIn3D[i][j] = originalDirection[i][j]; | ||
| } | ||
| } | ||
| imageManager->SetOriginalDirection(originalDirectionIn3D); | ||
| */ | ||
| //auto tempImage = cbica::GetImageOrientation< ImageTypeFloat4D >(imagePerf); | ||
| //imageManager->SetOriginalOrientation(tempImage.first); | ||
| //imagePerf = ChangeImageDirectionToIdentity< ImageTypeFloat4D >(tempImage.second); |
There was a problem hiding this comment.
Any reason for this commented code to be present? If yes, then please place a comment here.
Comment on lines
+224
to
+229
| //currentSubjectDir.setFilter(QDir::Files | QDir::Readable); | ||
| //QStringList perfNameFilters, drawingNameFilters; | ||
| //perfNameFilters << "*perf*.nii.gz" << "*DSC*.nii.gz"; | ||
| //auto possibleInputFiles = currentSubjectDir.entryList(perfNameFilters); | ||
| //drawingNameFilters << "*mask*.nii.gz" << "*labels*.nii.gz"; | ||
| //auto possibleDrawingFiles = currentSubjectDir.entryList(); |
There was a problem hiding this comment.
Do we need this? If so, then comment, otherwise please remove.
|
I'll remove that commented code in the PR that updates the docs and version. Thanks @sarthakpati ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1472
Fixed #1473
Fixed #1474
Fixed #1475
Seems to have also fixed #1450
Summary:
Adds a text indicator of 4D slice number to the slider bar.
Clarifies perfusionPCA filename requirements (but doesn't make them more intelligent).
Fixes loading of 4D and 3D images together.
Adds batch mode and time-points parameters to PHI (EGFRvIIISurrogateIndex).
Also disables self-host mac builds in the Azure pipeline. @sarthakpati may need to configure the requirements on GitHub side, not sure about that.