Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added parse() to handle options advertised by makeself, added more te… #1480

Merged
merged 1 commit into from
Mar 9, 2022
Merged

added parse() to handle options advertised by makeself, added more te… #1480

merged 1 commit into from
Mar 9, 2022

Conversation

MarkBergman-cbica
Copy link
Collaborator

…sts for failures, sent error and warning messages to stderr

Fixes issue #1222

Proposed Changes

@MarkBergman-cbica
added parse() to handle options advertised by makeself, added more te…
7b60390 
…sts for failures, sent error and warning messages to stderr
AlexanderGetka-cbica
AlexanderGetka-cbica approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@AlexanderGetka-cbica AlexanderGetka-cbica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I trust I can ask for help tomorrow if anything goes wrong during packaging :^)

@AlexanderGetka-cbica AlexanderGetka-cbica merged commit f1181f8 into master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderGetka-cbica AlexanderGetka-cbica AlexanderGetka-cbica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkBergman-cbica @AlexanderGetka-cbica