Add SmileGAN Plugin #191
Add SmileGAN Plugin #191
Conversation
There was a problem hiding this comment.
Thanks @zhijian-yang for putting in this PR. I added a few comments. I was not able to understand if the new files differ from the ones that are already a part of Compute Spares plugin.
NiBAx/plugins/SmileGAN/SmileGAN.py
Outdated
| self.plotCanvas.axes = self.plotCanvas.fig.add_subplot(111) | ||
| self.SPAREs = None | ||
| self.ui.stackedWidget.setCurrentIndex(0) | ||
| self.ui.factorial_progressBar.setValue(0) |
There was a problem hiding this comment.
Please change the name of progressBar. It says 'factorial_progressBar' and is confusing since there is no factorial computation.
NiBAx/plugins/SmileGAN/SmileGAN.py
Outdated
| from NiBAx.core.baseplugin import BasePlugin | ||
| from NiBAx.core.gui.SearchableQComboBox import SearchableQComboBox | ||
|
|
||
| class computeSPAREs(QtWidgets.QWidget,BasePlugin): |
There was a problem hiding this comment.
Without going through every single line, this class seems to be a copy of computespares.py. If so, we might not need to duplicate it here, we could just instantiate that one.
NiBAx/plugins/SmileGAN/SmileGAN.py
Outdated
| self.PopulateHue() | ||
|
|
||
|
|
||
| class BrainAgeWorker(QtCore.QObject): |
There was a problem hiding this comment.
This class also looks like a duplicate of the one in computeSpares.py. Can we not re-use that?
There was a problem hiding this comment.
Sorry for the confusion. I am adding a Smile-GAN plugin with Ahmed step by step now, so it is still in progress and it is now mostly copied from compute-spare.
There was a problem hiding this comment.
@zhijian-yang Is this PR still a work in progress? If yes, we can convert this into a draft.
Also, if you want to re-use code from ComputeSpares class, a better approach is to derive from that class.
|
Hi, I have completed one version of SmileGAN plugin. Please check and tell me how I should improve it. Thanks! |
|
Thanks @zhijian-yang |
No description provided.