Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1740 Redesign History Dialog component #501

Merged
merged 10 commits into from
Oct 24, 2024
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Oct 18, 2024

Overview

This PR introduces a rewrite of the History Dialog's underlying component, which incorporates a design update and an additional field indicating which user performed the history transition.

Note

This design change impacts the Submission Request too, but the "User" column won't appear there (intentionally) since we don't get userName from the getApplication API.

Change Details (Specifics)

  • Rewrite the History Dialog to be slightly more efficient (memoization and optimizing usage of callbacks, etc)
  • Rebuild the dialog UX without the MUI timeline (we essentially weren't using anything from it)
  • Add support for custom styling on the TruncatedText component
  • Minor updates to unit tests that were impacted by changes
  • Attempt to resolve transition-based ACT warnings by disabling MUI transitions Did not work

Related Ticket(s)

CRDCDH-1740 (FE Task)
CRDCDH-1741 (Design)
CRDCDH-1697 (User Story)

@amattu2 amattu2 added this to the 3.1.0 (PMVP-M2) milestone Oct 18, 2024
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Oct 18, 2024
@amattu2 amattu2 marked this pull request as ready for review October 21, 2024 19:06
@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Oct 21, 2024
@amattu2 amattu2 added 🚧 Do Not Merge This PR is not ready for merging and removed 🚧 Do Not Merge This PR is not ready for merging labels Oct 22, 2024
Base automatically changed from CRDCDH-1739 to 3.1.0 October 23, 2024 14:26
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor styling changes suggested. Feel free to disregard any if you feel otherwise. Everything else LGTM!

src/components/HistoryDialog/index.tsx Show resolved Hide resolved
src/components/HistoryDialog/index.tsx Show resolved Hide resolved
src/components/HistoryDialog/index.tsx Outdated Show resolved Hide resolved
@Alejandro-Vega Alejandro-Vega added the 📝 Change Requested This PR has requested changes label Oct 23, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 11506423831

Details

  • 31 of 31 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 52.218%

Totals Coverage Status
Change from base Build 11503533604: 0.2%
Covered Lines: 3478
Relevant Lines: 6169

💛 - Coveralls

@amattu2 amattu2 removed the 📝 Change Requested This PR has requested changes label Oct 24, 2024
@Alejandro-Vega Alejandro-Vega added the 📝 Change Requested This PR has requested changes label Oct 24, 2024
@amattu2 amattu2 removed the 📝 Change Requested This PR has requested changes label Oct 24, 2024
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit 9fb9559 into 3.1.0 Oct 24, 2024
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-1740 branch October 24, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants