Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1308 #149

Merged
merged 4 commits into from
Jul 9, 2024
Merged

CRDCDH-1308 #149

merged 4 commits into from
Jul 9, 2024

Conversation

kuffelgr
Copy link
Contributor

@kuffelgr kuffelgr commented Jul 3, 2024

This is to support CRDCDH-1234

ICDC Data Model changes are required in order to support integration into the CRDC Data Hub (DH).

Changes Detailed Below:

icdc-model.yml

  • Add version number
  • Add crdc_id prop to all nodes
  • Add file_id prop to file node for DCF guids supplied by Data Hub

icdc-model-props.yml

  • Add template tag for crdc_id
  • Change uuid, file_status, and file_location to "not required" since these values be generated by the DH in the future.

@kuffelgr kuffelgr requested review from majensen and PhilipMusk July 3, 2024 20:20
Copy link
Collaborator

@majensen majensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the data hub really create a CRDC ID for all these entities? I thought it was basically patient, sample, and file.

@majensen
Copy link
Collaborator

majensen commented Jul 8, 2024

Will the data hub really create a CRDC ID for all these entities? I thought it was basically patient, sample, and file.

Another way of framing this question: is there an explicit document from DH specifying the nodes for which they will create common ids?

@kuffelgr
Copy link
Contributor Author

kuffelgr commented Jul 8, 2024

Will the data hub really create a CRDC ID for all these entities? I thought it was basically patient, sample, and file.

Another way of framing this question: is there an explicit document from DH specifying the nodes for which they will create common ids?

I'm not sure @majensen . The instructions in the ticket I am working on required crdc_id to be added to all nodes.
https://tracker.nci.nih.gov/browse/CRDCDH-1308

Copy link
Collaborator

@majensen majensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this, since these extra ids won't hurt anything. But we should continue to try to resolve this question with Ming.

@kuffelgr kuffelgr merged commit 4cc57a7 into develop Jul 9, 2024
2 checks passed
@kuffelgr kuffelgr deleted the CRDCDH-1308 branch July 9, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants