Merge branch 'socks5' into dev2 #33
Annotations
39 warnings
you are using an explicit closure for cloning elements:
azalea/src/swarm/mod.rs#L601
warning: you are using an explicit closure for cloning elements
--> azalea/src/swarm/mod.rs:601:25
|
601 | let proxy = self.proxies.choose(&mut thread_rng()).map(|p| p.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.proxies.choose(&mut thread_rng()).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
|
this `let...else` may be rewritten with the `?` operator:
azalea/src/pathfinder/world.rs#L160
warning: this `let...else` may be rewritten with the `?` operator
--> azalea/src/pathfinder/world.rs:160:9
|
160 | / let Some(chunk) = world.chunks.get(&chunk_pos) else {
161 | | return None;
162 | | };
| |__________^ help: replace it with: `let chunk = world.chunks.get(&chunk_pos)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
unused import: `time::Duration`:
azalea/src/swarm/mod.rs#L17
warning: unused import: `time::Duration`
--> azalea/src/swarm/mod.rs:17:77
|
17 | use std::{collections::HashMap, future::Future, net::SocketAddr, sync::Arc, time::Duration};
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
manual implementation of `Option::map`:
azalea-protocol/src/connect.rs#L281
warning: manual implementation of `Option::map`
--> azalea-protocol/src/connect.rs:281:28
|
281 | let auth = match proxy.auth {
| ____________________________^
282 | | Some(user_key) => Some(user_key),
283 | | None => None,
284 | | };
| |_________________^ help: try: `proxy.auth.map(|user_key| user_key)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
|
this match expression is unnecessary:
azalea-protocol/src/connect.rs#L281
warning: this match expression is unnecessary
--> azalea-protocol/src/connect.rs:281:28
|
281 | let auth = match proxy.auth {
| ____________________________^
282 | | Some(user_key) => Some(user_key),
283 | | None => None,
284 | | };
| |_________________^ help: replace it with: `proxy.auth`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match
= note: `#[warn(clippy::needless_match)]` on by default
|
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
you are using an explicit closure for cloning elements:
azalea/src/swarm/mod.rs#L601
warning: you are using an explicit closure for cloning elements
--> azalea/src/swarm/mod.rs:601:25
|
601 | let proxy = self.proxies.choose(&mut thread_rng()).map(|p| p.clone());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.proxies.choose(&mut thread_rng()).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
= note: `#[warn(clippy::map_clone)]` on by default
|
this `let...else` may be rewritten with the `?` operator:
azalea/src/pathfinder/world.rs#L160
warning: this `let...else` may be rewritten with the `?` operator
--> azalea/src/pathfinder/world.rs:160:9
|
160 | / let Some(chunk) = world.chunks.get(&chunk_pos) else {
161 | | return None;
162 | | };
| |__________^ help: replace it with: `let chunk = world.chunks.get(&chunk_pos)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
unused import: `time::Duration`:
azalea/src/swarm/mod.rs#L17
warning: unused import: `time::Duration`
--> azalea/src/swarm/mod.rs:17:77
|
17 | use std::{collections::HashMap, future::Future, net::SocketAddr, sync::Arc, time::Duration};
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
assigning the result of `Clone::clone()` may be inefficient:
azalea-client/src/packet_handling/game.rs#L561
warning: assigning the result of `Clone::clone()` may be inefficient
--> azalea-client/src/packet_handling/game.rs:561:29
|
561 | ... info.display_name = updated_info.display_name.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `info.display_name.clone_from(&updated_info.display_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
the item `Query` is imported redundantly:
azalea-client/src/local_player.rs#L8
warning: the item `Query` is imported redundantly
--> azalea-client/src/local_player.rs:8:80
|
8 | use bevy_ecs::{component::Component, entity::Entity, prelude::*, query::Added, system::Query};
| ---------- ^^^^^^^^^^^^^
| |
| the item `Query` is already imported here
|
the item `Added` is imported redundantly:
azalea-client/src/local_player.rs#L8
warning: the item `Added` is imported redundantly
--> azalea-client/src/local_player.rs:8:66
|
8 | use bevy_ecs::{component::Component, entity::Entity, prelude::*, query::Added, system::Query};
| ---------- ^^^^^^^^^^^^
| |
| the item `Added` is already imported here
|
the item `Entity` is imported redundantly:
azalea-client/src/local_player.rs#L8
warning: the item `Entity` is imported redundantly
--> azalea-client/src/local_player.rs:8:38
|
8 | use bevy_ecs::{component::Component, entity::Entity, prelude::*, query::Added, system::Query};
| ^^^^^^^^^^^^^^ ---------- the item `Entity` is already imported here
|
= note: `#[warn(unused_imports)]` on by default
|
manual implementation of `Option::map`:
azalea-protocol/src/connect.rs#L281
warning: manual implementation of `Option::map`
--> azalea-protocol/src/connect.rs:281:28
|
281 | let auth = match proxy.auth {
| ____________________________^
282 | | Some(user_key) => Some(user_key),
283 | | None => None,
284 | | };
| |_________________^ help: try: `proxy.auth.map(|user_key| user_key)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
|
this match expression is unnecessary:
azalea-protocol/src/connect.rs#L281
warning: this match expression is unnecessary
--> azalea-protocol/src/connect.rs:281:28
|
281 | let auth = match proxy.auth {
| ____________________________^
282 | | Some(user_key) => Some(user_key),
283 | | None => None,
284 | | };
| |_________________^ help: replace it with: `proxy.auth`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match
= note: `#[warn(clippy::needless_match)]` on by default
|
the item `TryInto` is imported redundantly:
azalea-physics/src/collision/mergers.rs#L1
warning: the item `TryInto` is imported redundantly
--> azalea-physics/src/collision/mergers.rs:1:26
|
1 | use std::{cmp::Ordering, convert::TryInto};
| ^^^^^^^^^^^^^^^^
--> /rustc/3c85e56249b0b1942339a6a989a971bf6f1c9e0f/library/std/src/prelude/mod.rs:129:13
|
= note: the item `TryInto` is already defined here
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-registry/azalea-registry-macros/src/lib.rs#L4
warning: the item `syn` is imported redundantly
--> azalea-registry/azalea-registry-macros/src/lib.rs:4:5
|
4 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-block/azalea-block-macros/src/lib.rs#L11
warning: the item `syn` is imported redundantly
--> azalea-block/azalea-block-macros/src/lib.rs:11:5
|
11 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-buf/azalea-buf-macros/src/lib.rs#L6
warning: the item `syn` is imported redundantly
--> azalea-buf/azalea-buf-macros/src/lib.rs:6:11
|
6 | use syn::{self, parse_macro_input, DeriveInput};
| ^^^^ the item `syn` is already defined by prelude
|
the item `syn` is imported redundantly:
azalea-buf/azalea-buf-macros/src/write.rs#L3
warning: the item `syn` is imported redundantly
--> azalea-buf/azalea-buf-macros/src/write.rs:3:11
|
3 | use syn::{self, punctuated::Punctuated, token::Comma, Data, Field, FieldsNamed, Ident};
| ^^^^ the item `syn` is already defined by prelude
|
the item `syn` is imported redundantly:
azalea-buf/azalea-buf-macros/src/read.rs#L2
warning: the item `syn` is imported redundantly
--> azalea-buf/azalea-buf-macros/src/read.rs:2:11
|
2 | use syn::{self, punctuated::Punctuated, token::Comma, Data, Field, FieldsNamed, Ident};
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-inventory/azalea-inventory-macros/src/lib.rs#L11
warning: the item `syn` is imported redundantly
--> azalea-inventory/azalea-inventory-macros/src/lib.rs:11:11
|
11 | use syn::{self, parse_macro_input, Ident};
| ^^^^ the item `syn` is already defined by prelude
|
the item `syn` is imported redundantly:
azalea-inventory/azalea-inventory-macros/src/parse_macro.rs#L2
warning: the item `syn` is imported redundantly
--> azalea-inventory/azalea-inventory-macros/src/parse_macro.rs:2:5
|
2 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-protocol/azalea-protocol-macros/src/lib.rs#L4
warning: the item `syn` is imported redundantly
--> azalea-protocol/azalea-protocol-macros/src/lib.rs:4:5
|
4 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
assigning the result of `Clone::clone()` may be inefficient:
azalea-brigadier/src/context/command_context_builder.rs#L83
warning: assigning the result of `Clone::clone()` may be inefficient
--> azalea-brigadier/src/context/command_context_builder.rs:83:9
|
83 | self.modifier = node.read().modifier.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.modifier.clone_from(&node.read().modifier)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
assigning the result of `Clone::clone()` may be inefficient:
azalea-brigadier/src/context/command_context_builder.rs#L66
warning: assigning the result of `Clone::clone()` may be inefficient
--> azalea-brigadier/src/context/command_context_builder.rs:66:9
|
66 | self.command = command.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.command.clone_from(command)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
the item `syn` is imported redundantly:
azalea-protocol/azalea-protocol-macros/src/lib.rs#L4
warning: the item `syn` is imported redundantly
--> azalea-protocol/azalea-protocol-macros/src/lib.rs:4:5
|
4 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-block/azalea-block-macros/src/lib.rs#L11
warning: the item `syn` is imported redundantly
--> azalea-block/azalea-block-macros/src/lib.rs:11:5
|
11 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-inventory/azalea-inventory-macros/src/lib.rs#L11
warning: the item `syn` is imported redundantly
--> azalea-inventory/azalea-inventory-macros/src/lib.rs:11:11
|
11 | use syn::{self, parse_macro_input, Ident};
| ^^^^ the item `syn` is already defined by prelude
|
the item `syn` is imported redundantly:
azalea-inventory/azalea-inventory-macros/src/parse_macro.rs#L2
warning: the item `syn` is imported redundantly
--> azalea-inventory/azalea-inventory-macros/src/parse_macro.rs:2:5
|
2 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-registry/azalea-registry-macros/src/lib.rs#L4
warning: the item `syn` is imported redundantly
--> azalea-registry/azalea-registry-macros/src/lib.rs:4:5
|
4 | self, braced,
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|
the item `syn` is imported redundantly:
azalea-buf/azalea-buf-macros/src/lib.rs#L6
warning: the item `syn` is imported redundantly
--> azalea-buf/azalea-buf-macros/src/lib.rs:6:11
|
6 | use syn::{self, parse_macro_input, DeriveInput};
| ^^^^ the item `syn` is already defined by prelude
|
the item `syn` is imported redundantly:
azalea-buf/azalea-buf-macros/src/write.rs#L3
warning: the item `syn` is imported redundantly
--> azalea-buf/azalea-buf-macros/src/write.rs:3:11
|
3 | use syn::{self, punctuated::Punctuated, token::Comma, Data, Field, FieldsNamed, Ident};
| ^^^^ the item `syn` is already defined by prelude
|
the item `syn` is imported redundantly:
azalea-buf/azalea-buf-macros/src/read.rs#L2
warning: the item `syn` is imported redundantly
--> azalea-buf/azalea-buf-macros/src/read.rs:2:11
|
2 | use syn::{self, punctuated::Punctuated, token::Comma, Data, Field, FieldsNamed, Ident};
| ^^^^ the item `syn` is already defined by prelude
|
= note: `#[warn(unused_imports)]` on by default
|