Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 4 Lenovo GPU Nodes #65

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

hakasapl
Copy link
Contributor

These nodes are booted UEFI, which needs to stay (having 4 GPUs per node often doesn't play nice with BIOS mode)

nodes/bm_inventory_r8pac23.json Outdated Show resolved Hide resolved
@hakasapl hakasapl requested a review from tzumainn June 7, 2024 19:20
Copy link
Contributor

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joachimweyl
Copy link

@hakasapl can you add notes as to why we are holding off on merging?

@hakasapl
Copy link
Contributor Author

hakasapl commented Jul 3, 2024

These nodes were given to a group that is using them outside of ESI. I'm okay with merging this but we may also want to hold off since these nodes are not in ESI yet. @tzumainn thoughts?

@tzumainn
Copy link
Contributor

tzumainn commented Jul 4, 2024

I think I'm fine with merging if you're okay with it; ESI successfully powered them on and provisioned them - just not with UEFI boot.

@joachimweyl
Copy link

@tzumainn have we now resolved the UEFI boot issue?

@tzumainn
Copy link
Contributor

Yep; we just haven't specifically tested on these nodes, since they're currently in use.

@tzumainn
Copy link
Contributor

tzumainn commented Aug 8, 2024

Just a note that these nodes are now back to being managed in ESI, and from testing they boot properly in UEFI mode. @hakasapl if you resolve the merge conflicts I think this is definitely ready to merge!

@hakasapl
Copy link
Contributor Author

hakasapl commented Aug 8, 2024

@tzumainn should be all set

@tzumainn
Copy link
Contributor

tzumainn commented Aug 8, 2024

Thanks!

@tzumainn tzumainn merged commit 6e23c2c into CCI-MOC:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants