Add Lessee Offer View #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzumainn
requested changes
Jul 10, 2024
tzumainn
requested changes
Jul 16, 2024
There was a problem hiding this comment.
- don't forget to squash the commits!
- make sure your commit message lists what panels have changed, so it's easier to test them out
- when claiming an offer, I think the dates aren't being passed in; I tried creating a one day lease, and the lease that came back was for max time
- on the offer page, I think it may be important to show the availabilities without asking the user to click on the "expand" arrow
- on the Nodes panel, do we show future leases? it probably makes sense to, but it would change the logic of that page (where we show all leases, and then add node information only if it exists)
- Add offers table - Able to claim offers with time periods - Add lease cancel functionality - Able to see and cancel future leases with limited information - Able to see lease status
tzumainn
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.