Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imgtool fix for new backend #27

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Add imgtool fix for new backend #27

merged 4 commits into from
Apr 22, 2024

Conversation

IsaacKhor
Copy link
Member

  • Remove rados backend option
  • Change pool to be an explicit option

@IsaacKhor
Copy link
Member Author

@knikolla added the image create, but we should add tests for all the code paths in a script somewhere and run that instead

Probably merge in thick-image (which just provisions all the objects up-front) into imgtool too

@knikolla
Copy link
Contributor

@knikolla added the image create, but we should add tests for all the code paths in a script somewhere and run that instead

Probably merge in thick-image (which just provisions all the objects up-front) into imgtool too

@IsaacKhor Totally. For now this is merely a way to test that the issue which this PR is meant to fix (context creation) is actually fixed and to avoid the regression of this particular one issue.

One a different note, we should really make the keyring name and ceph.conf location customizable.

Copy link
Contributor

@knikolla knikolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@knikolla knikolla merged commit 23ee44e into main Apr 22, 2024
1 check passed
@knikolla knikolla deleted the imgtool-fix branch April 22, 2024 20:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants