node network list now calls from esisdk #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzumainn
requested changes
Jun 28, 2024
ajamias
force-pushed
the
master
branch
2 times, most recently
from
21f0821
to
67d4aa0
Compare
tzumainn
requested changes
Jul 2, 2024
| @@ -24,7 +24,7 @@ class TestList(base.TestCommand): | |||
|
|
|||
| def setUp(self): | |||
| super(TestList, self).setUp() | |||
| self.cmd = node_network.List(self.app, None) | |||
| self.maxDiff = None | |||
There was a problem hiding this comment.
I don't think this is needed (at least from my testing).
There was a problem hiding this comment.
Ah that was for my debugging, I'll get rid of it now
Many projects want to use the functionality that previously existed in this project. That functionality has been moved to esisdk to centralize the logic, and to not repeat the same code.
tzumainn
approved these changes
Jul 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To centralize logic, the
esi node network listwill call from esisdk.