Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set env variable for api version in python context #66

Merged
merged 2 commits into from
Jul 19, 2024
Merged

set env variable for api version in python context #66

merged 2 commits into from
Jul 19, 2024

Conversation

sheldor1510
Copy link
Contributor

tzumainn
tzumainn requested changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@tzumainn tzumainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well! The only request I have is to make the baremetal API version a constant at the top of the file; that will make it more apparent and easier to change in the future if needed.

@tzumainn tzumainn merged commit 3ab0c27 into CCI-MOC:master Jul 19, 2024
6 checks passed
@sheldor1510 sheldor1510 deleted the api-version-error branch July 19, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzumainn tzumainn tzumainn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheldor1510 @tzumainn