Migrate Node Network Functionality to esisdk #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzumainn
requested changes
Jul 24, 2024
ajamias
changed the title
This commit is to reflect the changes to move the network attach and detach functionality to esisdk. This is so that both python-esiclient and esi-ui can use this functionality.
tzumainn
approved these changes
Jul 24, 2024
|
Should we take python<=3.7 tests out? The tests are giving an error |
|
Yeah, I submitted a PR for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to reflect the changes to move the
network attach functionality to esisdk. This is so that both python-esiclient and esi-ui can use this functionality.