Update the stations method to return all active stations
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDJellen
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of core changes:
This PR addresses issue #40 by changing the source of the stations data to the NDBC's full cataloge of active stations, rather than only reporting the set of stations directly owned and operated by the NDBC.
api.stations()the full collection of ~1380 stations is now available, along with their location and some limited metdata.api.nearest_station(...), all of these stations are now candidates, the same goes forapi.radial_search(...)api.historical_stations()which returns the full collection of all logged deployments of stations and buoys by NDBC or partner organizations, structured such that each row captures one deployment period.Future Improvements:
This change better aligns the API with the data offered by NDBC. #40 also makes an excellent suggestion for first-class netcdf support. This update is in progress, and will follow in a subsequent release.