fluids: Compatability for PETSc w/ 64bit ints #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwrigh
force-pushed
the
jrwrigh/fluids_64int
branch
4 times, most recently
from
e47e721
to
fe78553
Compare
jeremylt
reviewed
Jun 20, 2023
jrwrigh
force-pushed
the
jrwrigh/fluids_64int
branch
from
fe78553
to
302f2ac
Compare
- Not needed, as essential boundary conditions go through `DMPlexInsertBoundaryValues_NS` or `DMPlexInsertBoundaryValues_StrongBC`
- Also code into the token whether PETSc was coded using 32 or 64 bit integers
jrwrigh
force-pushed
the
jrwrigh/fluids_64int
branch
from
302f2ac
to
0de6a49
Compare
|
The PETSc MR is now merged onto |
jedbrown
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes fluids example compatible with PETSc builds using 64bit integers (ie.
--with-64-bit-indices=1).Note: depends on this PETSc MR for
PetscInt32support.