New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded guard in BasisDestroy #1242

Merged

jrwrigh merged 1 commit into main from jeremy/contract-destroy-cleanup

Jun 26, 2023

Member

jeremylt commented Jun 23, 2023

This guard isn't needed because calling Ceed*Destroy on a NULL is always fine


          minor - destroying null object is always safe

9831d45

jeremylt added minor 1-In Review labels

jeremylt self-assigned this

jrwrigh approved these changes

View reviewed changes

jrwrigh merged commit d1ca5d5 into main

jrwrigh deleted the jeremy/contract-destroy-cleanup branch

June 26, 2023 20:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1-In Review minor