rust - drop failing tests #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedbrown
approved these changes
Jan 23, 2024
|
There's a certain way you have to comment out otherwise it becomes code that's hidden in documentation but still part of the test. I don't recall the details |
jeremylt
added a commit
that referenced
this pull request
Sep 9, 2024
jeremylt
added a commit
that referenced
this pull request
Sep 10, 2024
jeremylt
added a commit
that referenced
this pull request
Sep 12, 2024
jeremylt
added a commit
that referenced
this pull request
Sep 17, 2024
jeremylt
added a commit
that referenced
this pull request
Sep 17, 2024
jeremylt
added a commit
that referenced
this pull request
Sep 20, 2024
jeremylt
added a commit
that referenced
this pull request
Sep 23, 2024
jeremylt
added a commit
that referenced
this pull request
Sep 27, 2024
jeremylt
added a commit
that referenced
this pull request
Oct 3, 2024
jeremylt
added a commit
that referenced
this pull request
Oct 3, 2024
jeremylt
added a commit
that referenced
this pull request
Oct 8, 2024
jeremylt
added a commit
that referenced
this pull request
Oct 8, 2024
jeremylt
added a commit
that referenced
this pull request
Oct 9, 2024
jeremylt
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the failing tests while we figure out how to fix this functionality