-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ux for new developers #1071
Ux for new developers #1071
Conversation
To Development section added new steps to provide better development environment.
Description about hot reload changed.
README.md
Outdated
@@ -16,6 +16,9 @@ and [building easy-to-read messages ready to be sent to the scanned organization | |||
|
|||
If you want to use additional modules that weren't included here due to non-BSD-compatible licenses, browse to the [Artemis-modules-extra](https://github.com/CERT-Polska/Artemis-modules-extra) repository. | |||
|
|||
If you work as a developer and you want to modify code, you have to do some modifications ⮕ **[Developers](#develop)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can all these changes be put in one place? e.g. ./scripts/start_develop that runs scripts/start with some tweaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe create docker-compose.prod.yaml and Dockerfile.prod and put as a variable in scritps/start_develop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but .dev ;)
I added new volume on web container, reload option in cmd command in DOckerfile. All changes are commented out and the code remains in its original version (downloadable for the user)