Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ux for new developers #1071

Merged
merged 14 commits into from
Jun 17, 2024
Merged

Ux for new developers #1071

merged 14 commits into from
Jun 17, 2024

Conversation

michalkrzem
Copy link
Collaborator

I added new volume on web container, reload option in cmd command in DOckerfile. All changes are commented out and the code remains in its original version (downloadable for the user)

To Development section added new steps to provide better development environment.
Code to push prepared (new line of code commented)
Description about hot reload changed.
README.md Outdated
@@ -16,6 +16,9 @@ and [building easy-to-read messages ready to be sent to the scanned organization

If you want to use additional modules that weren't included here due to non-BSD-compatible licenses, browse to the [Artemis-modules-extra](https://github.com/CERT-Polska/Artemis-modules-extra) repository.

If you work as a developer and you want to modify code, you have to do some modifications ⮕ **[Developers](#develop)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can all these changes be put in one place? e.g. ./scripts/start_develop that runs scripts/start with some tweaks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create docker-compose.prod.yaml and Dockerfile.prod and put as a variable in scritps/start_develop?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but .dev ;)

@kazet kazet merged commit 9419e4e into main Jun 17, 2024
3 of 4 checks passed
@kazet kazet deleted the ux_for_new_developers branch June 17, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants