-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain Scanner #1146
Open
kshitijk4poor
wants to merge
41
commits into
CERT-Polska:main
Choose a base branch
from
kshitijk4poor:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Domain Scanner #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazet
reviewed
Jul 18, 2024
kazet
reviewed
Aug 2, 2024
kazet
reviewed
Aug 2, 2024
kazet
reviewed
Aug 2, 2024
kazet
reviewed
Aug 3, 2024
@@ -214,7 +214,7 @@ def run(self, current_task: Task) -> None: | |||
}, | |||
) | |||
|
|||
self.add_task(current_task, new_task) | |||
self.add_task_if_domain_exists(current_task, new_task) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we have open ports, we can be sure the domain exists ;) but checking in classifier is a good idea as well as it processes incoming tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Implement domain validation and task addition for efficient scanning
📝 Description
This PR introduces two complementary methods in the
ArtemisBase
class:check_domain_exists
for domain validation andadd_valid_domains_task
for adding tasks for valid domains. The primary purpose of these additions is to ensure that only valid domains are sent for further scanning, improving efficiency and reducing unnecessary processing.🔧 Changes
check_domain_exists
andadd_valid_domains_task
method toArtemisBase
classArtemisModuleTestCase
to handle multiple arguments in lookup function calls, resolving TypeError in tests.🌟 Benefits
🤝 How the methods complement each other
check_domain_exists
verifies the validity of a domain by checking for NS or A recordsadd_valid_domains_task
usescheck_domain_exists
to filter out invalid domainsThis combination ensures a streamlined and efficient domain processing pipeline.
📝Testing
check_domain_exists
method to ensure all scenarios are covered, including:TODO
📚 Related Issues
Closes #1094