DomainExpirationScanner: more logging, timeouts accounting for the fact that we wait for quota, minor message fixes, etc. #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulkowy
reviewed
Nov 2, 2023
| self.log.info("Successful whois query for %s expiry=%s", domain, domain_data.expiration_date) | ||
| except WhoisQuotaExceeded: | ||
| self.log.info("Quota exceeded for whois query for %s", domain) | ||
| time.sleep(24 * 60 * 60) |
There was a problem hiding this comment.
hmmm, chcemy by worker spal caly dzien? Troche mi ten pomysl nie lezy, bardziej zarzadzilbym resched taska
There was a problem hiding this comment.
ale resched sprawi ze bedziemy napierdalac query() bo zaraz sie nowy task pojawi co sprobuje znow tego samego i moga nas 🔨
bulkowy
previously approved these changes
Nov 7, 2023
bulkowy
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.