possible error with the /add route , throws internal server error #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazet
requested changes
Mar 28, 2024
artemis/templating.py
Outdated
| @@ -17,10 +17,14 @@ | |||
|
|
|||
|
|
|||
| def dedent(text: str) -> str: | |||
| if(text==None): | |||
There was a problem hiding this comment.
if not text.
BTW, please run linter (according to https://github.com/cert-polska/artemis?tab=readme-ov-file#code-formatting)
added 2 commits
March 29, 2024 18:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #883
So if you write a custom module and you don't add your doc string, the
infokey in theKartonBindobject is empty and hence when we try to access the/addroute to add new targets, the method dedent and render_markdown in template.py throw an exception. This error was realised while I was writing custom modules and didn't bother to add the doc string. The line of interest in the jinja template where the input is piped to these methods is this.A simple check should solve the issue.