Analysis logs available in frontend #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chivay
force-pushed
the
analysis-logs
branch
2 times, most recently
from
e3c26ce to
2e82899
Compare
chivay
force-pushed
the
analysis-logs
branch
3 times, most recently
from
4837925 to
61a07e8
Compare
chivay
force-pushed
the
analysis-logs
branch
2 times, most recently
from
91990db to
18adddf
Compare
BonusPlay
reviewed
Sep 2, 2020
chivay
force-pushed
the
analysis-logs
branch
from
bc92510 to
6847cd0
Compare
|
@chivay ping me when you're done with fixes :) |
|
needs rebase as #223 is now merged |
icedevml
force-pushed
the
analysis-logs
branch
from
5bd0ce3 to
9cb4805
Compare
icedevml
approved these changes
Sep 27, 2020
fengjixuchui
added a commit
to fengjixuchui/drakvuf-sandbox
that referenced
this pull request
Sep 28, 2020
Analysis logs available in frontend (CERT-Polska#195)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #174 #185
blocked by #223
OK, so this PR is quite large I'm still missing #223 for it to work, however I'd like some feedback on what to change / what things should look like. The way each log entry is displayed isn't trivial and I'm still looking for ideas that would look nice and be feasible to code. Apart from that, the code is somewhat finished and works without any issues.
Consider only commit 18adddf as the other one is extracted into other PR
TODO:
This is a preview: