Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extensions to drakcore and drakpush. #205

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Added extensions to drakcore and drakpush. #205

merged 3 commits into from
Aug 13, 2020

Conversation

kscieslinski
Copy link
Contributor

@kscieslinski kscieslinski commented Aug 13, 2020

Drakrun expects that the extension is passed in task header. I've also moved timeout, start_command and override_uid from task_resources to task_payload as this is what drakrun expects.

drakrun/drakrun/main.py Outdated Show resolved Hide resolved
Copy link
Contributor

@icedevml icedevml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the frontend we have feature to manually specify the file name. Previously it applied to the full file name (i.e. file name WITH extension) so I suppose this is broken right now.

I think user should still be able to override the full file name (including extension).

@kscieslinski
Copy link
Contributor Author

kscieslinski commented Aug 13, 2020

In the frontend we have feature to manually specify the file name. Previously it applied to the full file name (i.e. file name WITH extension) so I suppose this is broken right now.

I think user should still be able to override the full file name (including extension).

This should be fine. We ask user only for filename but later on in drakcore/app.py upload endpoint and in drakrun/drakpush.py we divide the filename to filename without extension and extension. This is because drakrun requires so (for routing).

@kscieslinski kscieslinski merged commit ff97db2 into master Aug 13, 2020
@kscieslinski kscieslinski deleted the extensions branch August 13, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants