Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in AnalysisList.js #264

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Fix bug in AnalysisList.js #264

merged 2 commits into from
Oct 13, 2020

Conversation

icedevml
Copy link
Contributor

In some circumstances, the analysis bucket might contain invalid/corrupted/missing data. This shouldn't break analysis list completely (now: it does).

When there is any folder with missing metadata in the analysis result bucket:

Uncaught (in promise) RangeError: Invalid time value
    at Date.toISOString (<anonymous>)
    at a.value (AnalysisList.js:23)
    at AnalysisList.js:56
    at Array.map (<anonymous>)
    at a.value (AnalysisList.js:47)
    at Fa (react-dom.production.min.js:182)
    at Xa (react-dom.production.min.js:181)
    at df (react-dom.production.min.js:263)
    at ol (react-dom.production.min.js:246)
    at fl (react-dom.production.min.js:246)

@icedevml icedevml requested a review from chivay October 13, 2020 15:57
@chivay chivay added this to the Release v0.11.0 milestone Oct 13, 2020
@icedevml icedevml merged commit 5f104af into master Oct 13, 2020
@icedevml icedevml deleted the icedevml-patch-1 branch October 13, 2020 16:38
@icedevml icedevml mentioned this pull request Oct 14, 2020
Closed
@icedevml icedevml added the hacktoberfest-accepted Merged PRs might be labeled spontaneously by maintainer or upon author's request. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chivay chivay chivay approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Merged PRs might be labeled spontaneously by maintainer or upon author's request.
Projects
None yet
Milestone
Release v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@icedevml @chivay