Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MinIO credential generation on drakcore installation #290

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

icedevml
Copy link
Contributor

Currently we are using an approach in which drakcore automatically detects a single-node setup and then performs appropriate patching in /etc/drakcore/config.ini, /etc/drakrun/config.ini. Config files shipped by Debian package are managed and in some circumstances it causes bugs/credential desynchronization.

This PR moves to an approach in which there is one source of truth /etc/drakcore/minio.env, which is not on the list of conffiles in Debian package and is only generated automatically if it doesn't exist upon installation.

resolve #283

@icedevml icedevml requested a review from chivay October 16, 2020 01:56
@icedevml icedevml added this to the Release v0.11.0 milestone Oct 16, 2020
@icedevml icedevml force-pushed the fix-minio-creds branch 3 times, most recently from bbfa838 to 769e793 Compare October 16, 2020 23:31
@icedevml icedevml requested review from BonusPlay and chivay and removed request for BonusPlay and chivay October 18, 2020 21:10
Copy link
Collaborator

@chivay chivay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some serious doubts about minio.env file, patch_config, etc. It seems complex enough to break easily.

Why not simply create a wrapper script that loads the config, adds MINIO_* env variables and execs the minio server?
As for reconciliation between drakcore.ini and drakrun.ini, maybe load drakcore first and then maybe overwrite sections/vars with drakrun?

@icedevml
Copy link
Contributor Author

We've discussed this internally. None of considered paths seem to be the best, so for now let's stick with what's implemented here.

@icedevml icedevml merged commit d91731e into master Oct 20, 2020
@icedevml icedevml deleted the fix-minio-creds branch October 20, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package upgrade causes minio creds desynchronization
2 participants