drakrun, drakcore: Check size of uploaded log file #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If analysis emits no logs while processing a task, uploading log file to
object store will fail - karton disallows empty resources.
Skip uploading when there's no data.
Generated stacktrace:
Traceback (most recent call last):
File "/opt/venvs/drakcore/lib/python3.7/site-packages/drakcore/process.py", line 56, in wrapper
res.upload(self.backend)
File "/opt/venvs/drakcore/lib/python3.7/site-packages/karton/core/resource.py", line 322, in upload
raise RuntimeError("Can't upload resource without content")
RuntimeError: Can't upload resource without content
icedevml
approved these changes
May 11, 2021
chivay
added a commit
that referenced
this pull request
May 11, 2021
If analysis emits no logs while processing a task, uploading log file to
object store will fail - karton disallows empty resources.
Skip uploading when there's no data.
Generated stacktrace:
Traceback (most recent call last):
File "/opt/venvs/drakcore/lib/python3.7/site-packages/drakcore/process.py", line 56, in wrapper
res.upload(self.backend)
File "/opt/venvs/drakcore/lib/python3.7/site-packages/karton/core/resource.py", line 322, in upload
raise RuntimeError("Can't upload resource without content")
RuntimeError: Can't upload resource without content
|
Queued for v0.16.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If analysis emits no logs while processing a task, uploading log file to
object store will fail - karton disallows empty resources.
Skip uploading when there's no data.
Generated stacktrace: