Feature: brownout deprecated API features via enable_brownout flag #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
We're going to remove stale and deprecated features in next major version (v3.0.0). We're already tracking the usage of deprecated API elements but to ensure that we're ready to deploy breaking changes, we're going to temporarily "brownout" old features to check the effects.
What is the new behaviour?
This PR introduces
enable_brownoutflag. When enabled, deprecated API elements will throw HTTP 400 (Bad Request) with proper message. The exception islegacy_api_key_v2- we're not ready to drop it yet.