Fix: Change object.tags eager-load strategy to select-in #996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
[ ] I've added automated tests for my change (if applicable, optional)[ ] I've updated documentation to reflect my change (if applicable)What is the current behaviour?
Current eager-load strategy for
Object.tags
is joined load. It's the most basic eager-loading strategy in SQLAlchemy, but it doesn't combine well with loading relationships.When user tries to
GET /object/<hash>
, object information is returned along with all children/parents hashes and their tags. When we load this information from database usingjoined load
, it results in possibly excessive amount of rows:count(object) x count(tags)
where object information iscount(tags)
repeated along the rows. We see in our instance that for objects with several tags each, it may even cause an OOM condition.What is the new behaviour?
Object.tags
are switched to select-in load strategy. Using this strategy, sqlalchemy generates two queries: one for objects and one for tags for these objects. Then it merges the information from two queries by itself.This strategy generates much less heavy row set than the joined one.
Test plan
Checked manually if it is actually more efficient than previous strategy