Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/version.[ch]: Add version information API calls #2260

Closed
wants to merge 1 commit into from

Conversation

davischw
Copy link
Contributor

Add shared object library and project version information API calls. This will enable downstream projects to compare the library versions of the one installed on the system (via API calls) and the one linked against (via defines in 'version.h' during build) at runtime.

@davischw davischw force-pushed the version-api-calls branch from 8caf3bd to 8bfc170 Compare June 26, 2024 18:17
Add shared object library and project version information API calls.
This will enable downstream projects to compare the library versions of
the one installed on the system (via API calls) and the one linked
against (via defines in 'version.h' during build) at runtime.

Signed-off-by: David Schweizer <dschweizer@opensourcerouting.org>
@davischw davischw force-pushed the version-api-calls branch from 8bfc170 to b371ccf Compare June 26, 2024 18:33
Copy link
Member

@michalvasko michalvasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I suppose there is no issue with having the version in the API as well. But I am not sure so many functions and a structure is needed and would prefer to reduce the number of public symbols. Maybe just make the 2 structures public?

michalvasko added a commit that referenced this pull request Jun 28, 2024
@michalvasko
Copy link
Member

I want to make a new release so I adjusted it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants