-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(incoherence) : fixed incoherence and added new entrypoint #80
Conversation
pas le temps de tout regarder dans le détaille mais pour l'instant ca m'a l'air good :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A part le filtre qui a pas l'air de faire ce qui est prévu, le reste à l'air good !
Ça pourrait être pas mal de rajouter aussi le popup de confirmation sur la page des incohérence avec cette pr tant qu'à faire
Fix the Incoherence page:
This page was using getAllItems and was filtering on the front side
Change to create a new entry point /items/incoherent
Change front to use new entry point.
Fix the pager which use to give an extra page
This Incoherent méthode detect with there is item that are in stock but not buyable
and if a price is 0 or a displayprice is 0
New methode GetAllIncoherentItems can be improve by adding filters in the futur