Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(incoherence) : fixed incoherence and added new entrypoint #80

Merged
merged 13 commits into from
Jun 4, 2024

Conversation

BaptTF
Copy link
Contributor

@BaptTF BaptTF commented Apr 29, 2024

Fix the Incoherence page:
This page was using getAllItems and was filtering on the front side

Change to create a new entry point /items/incoherent
Change front to use new entry point.

Fix the pager which use to give an extra page

This Incoherent méthode detect with there is item that are in stock but not buyable
and if a price is 0 or a displayprice is 0
New methode GetAllIncoherentItems can be improve by adding filters in the futur

@yyewolf yyewolf changed the title Bugfix/incoherence fix(incoherence) : fixed incoherence and added new entrypoint Apr 29, 2024
@yyewolf
Copy link
Member

yyewolf commented Apr 29, 2024

pas le temps de tout regarder dans le détaille mais pour l'instant ca m'a l'air good :D

Copy link
Contributor

@aripot007 aripot007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A part le filtre qui a pas l'air de faire ce qui est prévu, le reste à l'air good !

Ça pourrait être pas mal de rajouter aussi le popup de confirmation sur la page des incohérence avec cette pr tant qu'à faire

backend/internal/db/mongo/item_misc.go Outdated Show resolved Hide resolved
backend/internal/db/mongo/item_misc.go Outdated Show resolved Hide resolved
backend/autogen/utils.go Outdated Show resolved Hide resolved
backend/autogen/utils.go Outdated Show resolved Hide resolved
backend/internal/db/mongo/item_misc.go Show resolved Hide resolved
@BaptTF BaptTF requested a review from aripot007 June 3, 2024 15:17
@aripot007 aripot007 merged commit e197b7f into main Jun 4, 2024
2 checks passed
@aripot007 aripot007 deleted the bugfix/Incoherence branch June 4, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants