Change the build-docker.sh file to return exit code from build #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to rust-lang/cargo#3377 (comment) the cargo search doesn't update the index and later in the thread is pointed out this is unnecessary now. Which is good because this doesn't work anymore
…ng to register error status codes from `cargo build` in backend
CEbbinghaus
approved these changes
Feb 25, 2024
CEbbinghaus
added a commit
that referenced
this pull request
Mar 1, 2024
* chore: moved version file * chore: created symbolic link * feat: upgraded logging and added config * Fixed build errors * Changed to Json logs & improved some events * Replaced last references to log & expanded logging * Fixed log level regression & formatted everything * swapped version back keep original in backend * bugfix: removed newline and fixed code to trim * Added back trim fix * Reset version to master * chore: Fixed clippy lints * Added scan interval to config * Change the build-docker.sh file to return exit code from build (#18) * Change the build-docker.sh file to return exit code from build According to rust-lang/cargo#3377 (comment) the cargo search doesn't update the index and later in the thread is pointed out this is unnecessary now. Which is good because this doesn't work anymore * Version bump of Decky CLI to 0.0.2 should fix the Github Runner failing to register error status codes from `cargo build` in backend * Refactored events * chore: did some light refactoring * chore: updated log * chore: Updated Version --------- Co-authored-by: jfreuden <jfreuden@alumni.cmu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to rust-lang/cargo#3377 (comment) the cargo search doesn't update the index and later in the thread is pointed out this is unnecessary now. Which is good because this doesn't work anymore, and with the CLI changes will actually stop the build when it throws the error.