Skip to content

Commit

Permalink
Do not show some warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
tpadioleau committed Nov 27, 2023
1 parent bb9c5ea commit f1b20dd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ jobs:
-DKokkos_ENABLE_DEPRECATED_CODE_4=OFF \
-DKokkos_ENABLE_DEPRECATION_WARNINGS=OFF \
-DCMAKE_CXX_FLAGS="\
-Wall -Wextra -Wpedantic \
-Wall -Wextra -Wpedantic -Wno-sign-compare \
-Werror=vla \
-Werror=implicit-fallthrough \
${CMAKE_CXX_FLAGS}" \
Expand Down
4 changes: 2 additions & 2 deletions include/ddc/kernels/splines/spline_builder.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ void SplineBuilder<
operator()(
ddc::ChunkSpan<double, ddc::DiscreteDomain<bsplines_type>, Layout, MemorySpace> spline,
ddc::ChunkSpan<double, interpolation_domain_type, Layout, MemorySpace> vals,
std::optional<ddc::CDSpan1D> const derivs_xmin,
std::optional<ddc::CDSpan1D> const derivs_xmax) const
[[maybe_unused]] std::optional<ddc::CDSpan1D> const derivs_xmin,
[[maybe_unused]] std::optional<ddc::CDSpan1D> const derivs_xmax) const
{
assert(vals.template extent<interpolation_mesh_type>()
== ddc::discrete_space<BSplines>().nbasis() - s_nbe_xmin - s_nbe_xmax);
Expand Down

0 comments on commit f1b20dd

Please sign in to comment.